Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple stack limit tests. #766

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Add simple stack limit tests. #766

merged 5 commits into from
Sep 2, 2024

Conversation

yarkinwho
Copy link
Contributor

@yarkinwho yarkinwho commented Aug 20, 2024

Resolve #683

There are two tests, one for internal recursive calls and one for external calls.

According to https://docs.soliditylang.org/en/v0.8.15/control-structures.html#internal-function-calls, the ethereum actually have a limitation of 1024 for internal recursive calls. our limit seems higher than that, so we use 1024 for test.

For external calls, our contract has a much lower limit than ethereum. The test use 11 as the input, which is the current limit.

@yarkinwho yarkinwho requested a review from elmato August 20, 2024 06:48
@spoonincode
Copy link
Member

With AntelopeIO/spring#628 now merged the original test should operate as expected now

@yarkinwho yarkinwho merged commit 573956a into main Sep 2, 2024
3 checks passed
@yarkinwho yarkinwho deleted the yarkin/stack_limit_tests branch September 2, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression test for maximum supported nested call limit
3 participants