Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the public maven central relase of com.google.api.grpc:proto-goog… #238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sfc-gh-pbennes
Copy link

…le-common-protos

This fixes an issue of duplicate and possibly incompatible classes for
com/google/api and com/google/rpc proto generated classes. If a project
includes both api and proto-google-common-protos dependencies, there
will be duplicate classes on the class path. This is because:

  • these classes are vendored in this repo but not declared in the pom
  • the version of proto-google-common-protos used is not a public release in maven central

Similar to the issue in #171 that #237 will fix.

Signed-off-by: Preston Bennes [email protected]

…le-common-protos

This fixes an issue of duplicate and possibly incompatible classes for
com/google/api and com/google/rpc proto generated classes. If a project
includes both api and proto-google-common-protos dependencies, there
will be duplicate classes on the class path. This is because:
- these classes are vendored in this repo but not declared in the pom
- the version of proto-google-common-protos used is not a public release in maven central

Similar to the issue in envoyproxy#171 that envoyproxy#237 will fix.

Signed-off-by: Preston Bennes <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #238 (b0d8ad6) into main (e5b9700) will decrease coverage by 0.40%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #238      +/-   ##
============================================
- Coverage     82.48%   82.07%   -0.41%     
+ Complexity      275      274       -1     
============================================
  Files            31       31              
  Lines           982      982              
  Branches         78       78              
============================================
- Hits            810      806       -4     
- Misses          137      140       +3     
- Partials         35       36       +1     
Impacted Files Coverage Δ
...o/envoyproxy/controlplane/cache/TestResources.java 85.78% <0.00%> (-2.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5b9700...b0d8ad6. Read the comment docs.

@sfc-gh-pbennes
Copy link
Author

FWIW I also wanted to remove the other google protos but I couldn't find either the protos or classes in any published jar that looked like it was intentionally publishing them.

@slowsoul
Copy link

slowsoul commented Nov 6, 2023

@sfc-gh-pbennes Thanks for the PR! I recently got into the same issue and found this fix. Can any reviewers help review this PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants