-
Notifications
You must be signed in to change notification settings - Fork 500
test(ci): Install and run docker-mac-net-connect when running e2e on macos #6368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0e89455
to
110abd4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6368 +/- ##
==========================================
+ Coverage 70.77% 70.82% +0.04%
==========================================
Files 220 220
Lines 37132 37132
==========================================
+ Hits 26280 26298 +18
+ Misses 9308 9292 -16
+ Partials 1544 1542 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
110abd4
to
7882ff4
Compare
is_running() { | ||
brew services info docker-mac-net-connect --json 2>/dev/null | \ | ||
jq -e '.[] | .user != null' >/dev/null | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brew services info docker-mac-net-connect --json
provides following output while my testing.
[
{
"name": "docker-mac-net-connect",
"service_name": "homebrew.mxcl.docker-mac-net-connect",
"running": false,
"loaded": false,
"schedulable": false,
"pid": null,
"exit_code": null,
"user": "root",
"status": "none",
"file": "/Users/sudiptobaral/Library/LaunchAgents/homebrew.mxcl.docker-mac-net-connect.plist",
"registered": true,
"loaded_file": null,
"command": "/opt/homebrew/opt/docker-mac-net-connect/bin/docker-mac-net-connect",
"working_dir": null,
"root_dir": null,
"log_path": "/opt/homebrew/var/log/docker-mac-net-connect/std_out.log",
"error_log_path": "/opt/homebrew/var/log/docker-mac-net-connect/std_error.log",
"interval": null,
"cron": null
}
]
During testing, I noticed that "running": false
was returned even when docker-mac-net-connect
was clearly running. The only reliable indicator I found was the user
field:
- If the service is stopped, the user field is null.
- If the service is running, the user field is always populated (e.g., "root").
b23bb6f
to
d835b00
Compare
d835b00
to
bbd5f1d
Compare
…MacOS. Signed-off-by: sudipto baral <[email protected]>
Signed-off-by: sudipto baral <[email protected]>
Signed-off-by: sudipto baral <[email protected]>
Signed-off-by: sudipto baral <[email protected]>
Signed-off-by: sudipto baral <[email protected]>
bbd5f1d
to
39631ee
Compare
This PR introduces scripts to automate the setup and cleanup of docker-mac-net-connect for local macOS development environments.
Features
Automatically stop the service afterward.Users will be responsible for stopping the service if needed.DOCKER_MAC_NET_CONNECT=false
.Covered Logic
HOMEBREW_GOPROXY
.Fixes #6325