Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump com_github_cncf_xds to cncf/xds@0c46c01 #33160

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

sergiitk
Copy link
Contributor

@sergiitk sergiitk commented Mar 27, 2024

Changes: cncf/xds@6b7cb9e...0c46c01

  1. pgv_plugin_go : Use protoc_gen_validate instead of xds (pgv_plugin_go : Use protoc_gen_validate instead of xds cncf/xds#92)
  2. cel: Add canonical CEL (dev.cel.expr) fields (cel: Add canonical CEL (dev.cel.expr) fields cncf/xds#89)
    • dev_cel v0.15.0 dependency added
    • cel: Support canonical CEL in xds.type.v3.CelExpression

Commit Message:

deps: Bump `com_github_cncf_xds` to cncf/xds@0c46c01

Additional Description:

Changes: https://github.com/cncf/xds/compare/6b7cb9e...0c46c01

- pgv_plugin_go : Use protoc_gen_validate instead of xds(cncf/xds#92)
- cel: Add canonical CEL (dev.cel.expr) fields (cncf/xds#89)
  - [`dev_cel` v0.15.0]
    (https://github.com/google/cel-spec/releases/tag/v0.15.0)
    dependency added
  - cel: Support canonical CEL in xds.type.v3.CelExpression

Risk Level: Low
Testing: do_ci.sh
Docs Changes:
Release Notes:
Platform Specific Features:

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #33160 was opened by sergiitk.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Mar 27, 2024
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @phlax

🐱

Caused by: #33160 was opened by sergiitk.

see: more, trace.

@sergiitk sergiitk changed the title cel: Support canonical CEL in xds.type.v3.CelExpression deps: Bump com_github_cncf_xds to cncf/xds@0c46c01 Apr 1, 2024
@sergiitk sergiitk marked this pull request as ready for review April 1, 2024 05:11
@sergiitk
Copy link
Contributor Author

sergiitk commented Apr 1, 2024

@phlax this is ready for review now.

@phlax
Copy link
Member

phlax commented Apr 1, 2024

/retest

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @sergiitk

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Apr 1, 2024
@phlax phlax merged commit 805fc64 into envoyproxy:main Apr 1, 2024
53 checks passed
@sergiitk sergiitk deleted the cncf-xds-canonical-cel branch April 1, 2024 16:42
@sergiitk
Copy link
Contributor Author

sergiitk commented Apr 1, 2024

Thank you for the quick review, @phlax!

alyssawilk pushed a commit to alyssawilk/envoy that referenced this pull request Apr 29, 2024
cel: Support canonical CEL in xds.type.v3.CelExpression

Signed-off-by: Sergii Tkachenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants