Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: upgrade xds proto commit #18562

Merged
merged 1 commit into from
Oct 12, 2021
Merged

bazel: upgrade xds proto commit #18562

merged 1 commit into from
Oct 12, 2021

Conversation

markdroth
Copy link
Contributor

Signed-off-by: Mark D. Roth [email protected]

Commit Message: Update to latest commit of xDS protos.
Additional Description:
Risk Level: Low
Testing: None
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

CC @htuch

@markdroth
upgrade xds proto commit
22fb37e 
Signed-off-by: Mark D. Roth <[email protected]>
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #18562 was opened by markdroth.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 11, 2021
@markdroth
Copy link
Contributor Author

markdroth commented Oct 11, 2021 •
edited
Loading

This brings in cncf/xds#17 and is another step toward cncf/xds#2.

@markdroth markdroth mentioned this pull request Oct 11, 2021
Merged
htuch
htuch approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Oct 11, 2021
@moderation
Copy link
Contributor

MacOS CI errors - https://dev.azure.com/cncf/envoy/_build/results?buildId=91486&view=logs&j=fa3d3e18-6969-5713-c3e7-3581195704fd&t=ba370bef-ca49-52f5-0c93-7c0c0f27c465

@markdroth
Copy link
Contributor Author

That test looks unrelated to this PR. Could it be a flake?

@markdroth
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18562 (comment) was created by @markdroth.

see: more, trace.

@markdroth
Copy link
Contributor Author

The retest passed, so it looks like it was a flake.

I think this is ready to merge.

davinci26
davinci26 approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@davinci26 davinci26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, merging

@davinci26 davinci26 merged commit ea223b1 into envoyproxy:main Oct 12, 2021
@markdroth markdroth deleted the xds_proto_update branch October 12, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htuch htuch htuch approved these changes

@davinci26 davinci26 davinci26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markdroth @moderation @htuch @davinci26