Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FAB in Help Section to Scroll #925

Open
wants to merge 7 commits into
base: gsoc2022
Choose a base branch
from

Conversation

Akash-Ramjyothi
Copy link
Contributor

@Akash-Ramjyothi Akash-Ramjyothi commented Jun 27, 2022

Fixes: #928 .

Description:

Currently, the Help Activity has a lot of contents at once for Users to go through. Implemented a Floating Action Button in the Help Activity, by which when the user is scrolling down, a Button will appear through which he will directly be scrolled/ navigated to the top of the section. This will improve the UX of the app.

@Akash-Ramjyothi Akash-Ramjyothi changed the base branch from master to develop June 27, 2022 09:29
@Akash-Ramjyothi
Copy link
Contributor Author

@asaikarthikeya please review my PR.

@asaikarthikeya
Copy link
Member

Hello @Akash-Ramjyothi, Kindly add screenshots so that we could see the visual changes that you have made, Also rebase your PR's on top of the previous changes. Thanks

@Akash-Ramjyothi
Copy link
Contributor Author

FAB in Help Section:

WhatsApp.Video.2022-07-13.at.9.46.09.AM.mp4

@Akash-Ramjyothi Akash-Ramjyothi changed the base branch from develop to gsoc2022 August 27, 2022 19:15
@SebaDro SebaDro self-requested a review September 22, 2022 07:11
Copy link
Contributor

@SebaDro SebaDro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice feature. However, I would a expect the FAB to be sticky, so that users may scroll back to the top from anywhere. In addition, adjust the color of the FAB to be consistent with all other UI elements. Check the color of the FAB in the car list view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants