버전업 1.9.51 #717

Tnks2U · 2024-02-22T10:37:27Z

#710

fix: robokitRS 펌웨어 수정

HexaBoard_윈도우 연결문제 해결

로보타미 펌웨어 변경 및 시리얼 포드 선택 변경

지니로봇-토이봇 하드웨어 수정

잇플보드 PR입니다.

신규 실과로봇 추가

coco 신규등록

…to develop-hw

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

app/modules/ITPLE.js|173 col 25| Unexpected function expression.
app/modules/ITPLE.js|173 col 33| Unexpected space before function parentheses.
app/modules/ITPLE.js|174 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|199 col 41| Unexpected space before function parentheses.
app/modules/ITPLE.js|200 col 5| Unexpected var, use let or const instead.
app/modules/ITPLE.js|201 col 5| Unexpected var, use let or const instead.
app/modules/ITPLE.js|209 col 9| Unexpected var, use let or const instead.
app/modules/ITPLE.js|210 col 9| Unexpected var, use let or const instead.
app/modules/ITPLE.js|211 col 51| Unexpected function expression.
app/modules/ITPLE.js|211 col 59| Unexpected space before function parentheses.
app/modules/ITPLE.js|212 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|241 col 45| Unexpected space before function parentheses.
app/modules/ITPLE.js|242 col 5| Unexpected var, use let or const instead.
app/modules/ITPLE.js|246 col 49| Unexpected function expression.
app/modules/ITPLE.js|246 col 57| Unexpected space before function parentheses.
app/modules/ITPLE.js|248 col 31| Unexpected function expression.
app/modules/ITPLE.js|248 col 39| Unexpected space before function parentheses.
app/modules/ITPLE.js|261 col 44| Unexpected space before function parentheses.
app/modules/ITPLE.js|262 col 5| Unexpected var, use let or const instead.
app/modules/ITPLE.js|263 col 5| Unexpected var, use let or const instead.
app/modules/ITPLE.js|265 col 19| Unexpected function expression.
app/modules/ITPLE.js|265 col 27| Unexpected space before function parentheses.
app/modules/ITPLE.js|269 col 9| Unexpected var, use let or const instead.
app/modules/ITPLE.js|270 col 9| Unexpected var, use let or const instead.
app/modules/ITPLE.js|287 col 9| Unexpected var, use let or const instead.
app/modules/ITPLE.js|288 col 9| Unexpected var, use let or const instead.
app/modules/ITPLE.js|338 col 49| Unexpected space before function parentheses.
app/modules/ITPLE.js|339 col 5| Unexpected var, use let or const instead.
app/modules/ITPLE.js|340 col 5| Unexpected var, use let or const instead.
app/modules/ITPLE.js|366 col 9| 'value' is not defined.
app/modules/ITPLE.js|367 col 9| 'value' is not defined.
app/modules/ITPLE.js|369 col 41| 'value' is not defined.
app/modules/ITPLE.js|380 col 45| Unexpected space before function parentheses.
app/modules/ITPLE.js|381 col 5| Unexpected var, use let or const instead.
app/modules/ITPLE.js|382 col 5| Unexpected var, use let or const instead.
app/modules/ITPLE.js|383 col 5| Unexpected var, use let or const instead.
app/modules/ITPLE.js|395 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|429 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|430 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|431 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|432 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|477 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|478 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|487 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|488 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|489 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|490 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|491 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|492 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|493 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|494 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|495 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|496 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|497 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|498 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|499 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|500 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|501 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|502 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|576 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|577 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|578 col 13| Unexpected var, use let or const instead.
app/modules/ITPLE.js|600 col 44| Unexpected space before function parentheses.
app/modules/ITPLE.js|601 col 5| Unexpected var, use let or const instead.
app/modules/ITPLE.js|602 col 5| Unexpected var, use let or const instead.
app/modules/ITPLE.js|603 col 20| Unexpected function expression.
app/modules/ITPLE.js|603 col 28| Unexpected space before function parentheses.
app/modules/ITPLE.js|613 col 39| Unexpected space before function parentheses.
app/modules/ITPLE.js|614 col 5| Unexpected var, use let or const instead.
app/modules/ITPLE.js|621 col 34| Unexpected space before function parentheses.
app/modules/coco.js|164 col 33| Unexpected space before function parentheses.
app/modules/coco.js|166 col 42| Unexpected space before function parentheses.
app/modules/coco.js|171 col 47| Unexpected space before function parentheses.
app/modules/coco.js|177 col 45| Unexpected space before function parentheses.
app/modules/coco.js|186 col 41| Unexpected space before function parentheses.
app/modules/coco.js|193 col 46| Unexpected space before function parentheses.
app/modules/coco.js|197 col 46| Unexpected space before function parentheses.
app/modules/coco.js|209 col 45| Unexpected space before function parentheses.
app/modules/coco.js|281 col 41| Unexpected space before function parentheses.
app/modules/coco.js|325 col 45| Unexpected space before function parentheses.
app/modules/coco.js|345 col 44| Unexpected space before function parentheses.
app/modules/coco.js|456 col 49| Unexpected space before function parentheses.
app/modules/coco.js|510 col 13| 'value' is never reassigned. Use 'const' instead.
app/modules/coco.js|524 col 45| Unexpected space before function parentheses.
app/modules/coco.js|822 col 17| 'textLenBuf' is never reassigned. Use 'const' instead.
app/modules/coco.js|856 col 17| 'list' is never reassigned. Use 'const' instead.
app/modules/coco.js|857 col 17| 'line' is never reassigned. Use 'const' instead.
app/modules/coco.js|858 col 17| 'col' is never reassigned. Use 'const' instead.
app/modules/coco.js|876 col 13| Unexpected var, use let or const instead.
app/modules/coco.js|877 col 13| Unexpected var, use let or const instead.
app/modules/coco.js|878 col 13| Unexpected var, use let or const instead.
app/modules/coco.js|879 col 13| Unexpected var, use let or const instead.
app/modules/coco.js|880 col 13| Unexpected var, use let or const instead.
app/modules/coco.js|880 col 30| A function with a name starting with an uppercase letter should only be used as a constructor.
app/modules/coco.js|883 col 28| Unexpected string concatenation.
app/modules/coco.js|885 col 36| Unexpected string concatenation.
app/modules/coco.js|947 col 19| Identifier 'time_value' is not in camel case.
app/modules/coco.js|961 col 54| Identifier 'time_value' is not in camel case.
app/modules/coco.js|1027 col 44| Unexpected space before function parentheses.
app/modules/coco.js|1040 col 39| Unexpected space before function parentheses.
app/modules/coco.js|1048 col 34| Unexpected space before function parentheses.
app/modules/coco.js|1055 col 43| Unexpected space before function parentheses.
app/modules/jinirobot_toybot.js|14 col 32| Missing trailing comma.
app/modules/jinirobot_toybot.js|17 col 9| A space is required after '{'.
app/modules/jinirobot_toybot.js|17 col 35| A space is required before '}'.
app/modules/jinirobot_toybot.js|18 col 9| A space is required after '{'.
app/modules/jinirobot_toybot.js|18 col 35| A space is required before '}'.
app/modules/jinirobot_toybot.js|19 col 9| A space is required after '{'.
app/modules/jinirobot_toybot.js|19 col 35| A space is required before '}'.
app/modules/jinirobot_toybot.js|20 col 9| A space is required after '{'.
app/modules/jinirobot_toybot.js|20 col 35| A space is required before '}'.
app/modules/jinirobot_toybot.js|21 col 9| A space is required after '{'.
app/modules/jinirobot_toybot.js|21 col 35| A space is required before '}'.
app/modules/jinirobot_toybot.js|21 col 36| Missing trailing comma.
app/modules/jinirobot_toybot.js|22 col 6| Missing semicolon.
app/modules/jinirobot_toybot.js|49 col 9| A space is required after '{'.
app/modules/jinirobot_toybot.js|49 col 35| A space is required before '}'.
app/modules/jinirobot_toybot.js|49 col 36| Missing trailing comma.
app/modules/jinirobot_toybot.js|252 col 2| Missing semicolon.

github-actions · 2024-02-22T10:39:35Z

app/modules/ITPLE.js

+    this.isDraing = false;
+}
+
+var sensorIdx = 0;


⚠️ [eslint] <no-var> _{reported by reviewdog 🐶}
Unexpected var, use let or const instead.

Suggested change

var sensorIdx = 0;

let sensorIdx = 0;

github-actions · 2024-02-22T10:39:35Z

app/modules/ITPLE.js

+
+var sensorIdx = 0;
+
+Module.prototype.init = function (handler, config) {};


⚠️ [eslint] <space-before-function-paren> _{reported by reviewdog 🐶}
Unexpected space before function parentheses.

Suggested change

Module.prototype.init = function (handler, config) {};

Module.prototype.init = function(handler, config) {};

github-actions · 2024-02-22T10:39:35Z

app/modules/ITPLE.js

+
+Module.prototype.init = function (handler, config) {};
+
+Module.prototype.setSerialPort = function (sp) {


⚠️ [eslint] <space-before-function-paren> _{reported by reviewdog 🐶}
Unexpected space before function parentheses.

Suggested change

Module.prototype.setSerialPort = function (sp) {

Module.prototype.setSerialPort = function(sp) {

github-actions · 2024-02-22T10:39:35Z

app/modules/ITPLE.js

+Module.prototype.init = function (handler, config) {};
+
+Module.prototype.setSerialPort = function (sp) {
+    var self = this;


⚠️ [eslint] <no-var> _{reported by reviewdog 🐶}
Unexpected var, use let or const instead.

Suggested change

var self = this;

let self = this;

github-actions · 2024-02-22T10:39:35Z

app/modules/ITPLE.js

+    this.sp = sp;
+};
+
+Module.prototype.requestInitialData = function () {


⚠️ [eslint] <space-before-function-paren> _{reported by reviewdog 🐶}
Unexpected space before function parentheses.

Suggested change

Module.prototype.requestInitialData = function () {

Module.prototype.requestInitialData = function() {

github-actions · 2024-02-22T10:39:37Z

app/modules/ITPLE.js

+                    self.digitalPortTimeList[dataObj.port] = dataObj.time;
+                }
+            } else if (Array.isArray(dataObj.port)) {
+                isSend = dataObj.port.every(function (port) {


⚠️ [eslint] <space-before-function-paren> _{reported by reviewdog 🐶}
Unexpected space before function parentheses.

Suggested change

isSend = dataObj.port.every(function (port) {

isSend = dataObj.port.every(function(port) {

github-actions · 2024-02-22T10:39:37Z

app/modules/ITPLE.js

+                }
+            } else if (Array.isArray(dataObj.port)) {
+                isSend = dataObj.port.every(function (port) {
+                    var time = self.digitalPortTimeList[port];


⚠️ [eslint] <no-var> _{reported by reviewdog 🐶}
Unexpected var, use let or const instead.

Suggested change

var time = self.digitalPortTimeList[port];

let time = self.digitalPortTimeList[port];

github-actions · 2024-02-22T10:39:37Z

app/modules/ITPLE.js

+                });
+
+                if (isSend) {
+                    dataObj.port.forEach(function (port) {


⚠️ [eslint] <prefer-arrow-callback> _{reported by reviewdog 🐶}
Unexpected function expression.

Suggested change

dataObj.port.forEach(function (port) {

dataObj.port.forEach((port) => {

github-actions · 2024-02-22T10:39:37Z

app/modules/ITPLE.js

+                });
+
+                if (isSend) {
+                    dataObj.port.forEach(function (port) {


⚠️ [eslint] <space-before-function-paren> _{reported by reviewdog 🐶}
Unexpected space before function parentheses.

Suggested change

dataObj.port.forEach(function (port) {

dataObj.port.forEach(function(port) {

github-actions · 2024-02-22T10:39:37Z

app/modules/ITPLE.js

+    }
+
+    if (setDatas) {
+        var setKeys = Object.keys(setDatas);


⚠️ [eslint] <no-var> _{reported by reviewdog 🐶}
Unexpected var, use let or const instead.

Suggested change

var setKeys = Object.keys(setDatas);

let setKeys = Object.keys(setDatas);

irarykim and others added 30 commits January 19, 2024 08:22

RB-100 통합센서 지원

bee11eb

조립형 실과 및 bypass write 추가

bbba452

Dxl write 명령 지원 (read값 undefined 발생)

37e7f77

실과로봇 BLE 동글 지원

1bfee86

담당자 이메일 수정

2dee374

실과로봇 이미지 변경

ea27f74

임의의 길이 write 패킷 추가

a83f7e9

코드 정리

c44f658

실과로봇 유무선연결을 무선연결로 통합

aeb7750

이미지 크기 256x256으로 수정

4e0c642

연결및블록추가

c8fe598

Add files via upload

c077c87

Add files via upload

c0a31de

Add files via upload

4e73ab7

Add files via upload

8b28858

fix: robokitRS 펌웨어 수정

8fec187

아날로그67사용

94597fa

Hexaboard 윈도우 연결안되는 문제 개선

1d00e26

디버그 출력 삭제 / 실과로봇 com port 선택 생략

88e6265

Merge pull request #713 from RoboroboLab/develop-hw

845ada5

fix: robokitRS 펌웨어 수정

Merge pull request #715 from makeitnow-company/develop-hw

cdb8268

HexaBoard_윈도우 연결문제 해결

Merge pull request #712 from jdlee0320/develop-hw

b7274af

로보타미 펌웨어 변경 및 시리얼 포드 선택 변경

RB-100 제어기 연결시 초기화 작업 추가

0db7730

로봇아이 명칭, 이미지, 모듈 변경

449d34f

지니로봇 하드웨어 수정

21009b8

Merge pull request #716 from JINI-Robot/develop-hw

c6c07d3

지니로봇-토이봇 하드웨어 수정

Merge pull request #714 from Assembly95/develop-hw

959ad11

잇플보드 PR입니다.

Merge pull request #708 from irarykim/develop-hw

95ad572

신규 실과로봇 추가

version up : 1.9.51

f27aedf

feat: change win server

b9a3cf6

Tnks2U and others added 3 commits February 22, 2024 19:08

Merge pull request #711 from victoriaapple/develop-hw

9210fd1

coco 신규등록

feat: update mac server

84ec0e9

Merge branch 'develop-hw' of https://github.com/entrylabs/entry-hw in…

b2abe00

…to develop-hw

Tnks2U requested review from kimorkim and prisml February 22, 2024 10:37

Tnks2U self-assigned this Feb 22, 2024

Tnks2U merged commit 6425cfa into master Feb 22, 2024

github-actions bot reviewed Feb 22, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

버전업 1.9.51 #717

버전업 1.9.51 #717

Uh oh!

Tnks2U commented Feb 22, 2024

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot Feb 22, 2024

Uh oh!

github-actions bot Feb 22, 2024

Uh oh!

github-actions bot Feb 22, 2024

Uh oh!

github-actions bot Feb 22, 2024

Uh oh!

github-actions bot Feb 22, 2024

Uh oh!

github-actions bot Feb 22, 2024

Uh oh!

github-actions bot Feb 22, 2024

Uh oh!

github-actions bot Feb 22, 2024

Uh oh!

github-actions bot Feb 22, 2024

Uh oh!

github-actions bot Feb 22, 2024

Uh oh!

Uh oh!


		var sensorIdx = 0;

		Module.prototype.init = function (handler, config) {};

	Module.prototype.init = function (handler, config) {};
	Module.prototype.init = function(handler, config) {};


		Module.prototype.init = function (handler, config) {};

		Module.prototype.setSerialPort = function (sp) {

	Module.prototype.requestInitialData = function () {
	Module.prototype.requestInitialData = function() {

	isSend = dataObj.port.every(function (port) {
	isSend = dataObj.port.every(function(port) {

	var time = self.digitalPortTimeList[port];
	let time = self.digitalPortTimeList[port];

	dataObj.port.forEach(function (port) {
	dataObj.port.forEach((port) => {

	dataObj.port.forEach(function (port) {
	dataObj.port.forEach(function(port) {

	var setKeys = Object.keys(setDatas);
	let setKeys = Object.keys(setDatas);

버전업 1.9.51 #717

버전업 1.9.51 #717

Uh oh!

Conversation

Tnks2U commented Feb 22, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!