[1.9.49] 버전업 PR #698

Tnks2U · 2023-12-23T12:34:28Z

#693

씨큐브코딩 최초 커밋

펌웨어 추가 커밋

HEXA BOARD 최초 커밋

AIoT HW 변경

selectport true

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

app/modules/c3coding_arduino.js|175 col 29| Unexpected function expression.
app/modules/c3coding_arduino.js|175 col 37| Unexpected space before function parentheses.
app/modules/c3coding_arduino.js|176 col 17| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|210 col 28| Unexpected space before function parentheses.
app/modules/c3coding_arduino.js|211 col 9| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|212 col 9| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|215 col 13| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|216 col 13| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|217 col 55| Unexpected function expression.
app/modules/c3coding_arduino.js|217 col 63| Unexpected space before function parentheses.
app/modules/c3coding_arduino.js|218 col 17| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|234 col 9| Block must not be padded by blank lines.
app/modules/c3coding_arduino.js|250 col 32| Unexpected space before function parentheses.
app/modules/c3coding_arduino.js|251 col 9| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|255 col 53| Unexpected function expression.
app/modules/c3coding_arduino.js|255 col 61| Unexpected space before function parentheses.
app/modules/c3coding_arduino.js|257 col 35| Unexpected function expression.
app/modules/c3coding_arduino.js|257 col 43| Unexpected space before function parentheses.
app/modules/c3coding_arduino.js|269 col 31| Unexpected space before function parentheses.
app/modules/c3coding_arduino.js|270 col 9| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|271 col 9| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|273 col 23| Unexpected function expression.
app/modules/c3coding_arduino.js|273 col 31| Unexpected space before function parentheses.
app/modules/c3coding_arduino.js|277 col 13| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|278 col 13| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|295 col 13| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|296 col 13| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|325 col 36| Unexpected space before function parentheses.
app/modules/c3coding_arduino.js|326 col 9| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|327 col 9| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|352 col 13| 'value' is not defined.
app/modules/c3coding_arduino.js|353 col 13| 'value' is not defined.
app/modules/c3coding_arduino.js|364 col 45| 'value' is not defined.
app/modules/c3coding_arduino.js|375 col 32| Unexpected space before function parentheses.
app/modules/c3coding_arduino.js|376 col 9| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|377 col 9| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|378 col 9| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|397 col 17| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|423 col 31| Unexpected space before function parentheses.
app/modules/c3coding_arduino.js|424 col 9| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|425 col 9| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|426 col 24| Unexpected function expression.
app/modules/c3coding_arduino.js|426 col 32| Unexpected space before function parentheses.
app/modules/c3coding_arduino.js|436 col 26| Unexpected space before function parentheses.
app/modules/c3coding_arduino.js|437 col 9| Unexpected var, use let or const instead.
app/modules/c3coding_arduino.js|444 col 21| Unexpected space before function parentheses.
app/modules/c3coding_arduino.js|451 col 22| A constructor name should not start with a lowercase letter.
app/modules/c3coding_arduino.js|451 col 41| Newline required at end of file but not found.
app/modules/hexaboard.js|308 col 1| This line has a length of 137. Maximum allowed is 120.
app/modules/hexaboard.js|729 col 22| A constructor name should not start with a lowercase letter.

github-actions · 2023-12-23T12:36:32Z

app/modules/c3coding_arduino.js

@@ -0,0 +1,451 @@
+const BaseModule = require('./baseModule');
+
+class c3coding_arduino extends BaseModule {


⚠️ [eslint] <camelcase> _{reported by reviewdog 🐶}
Identifier 'c3coding_arduino' is not in camel case.

github-actions · 2023-12-23T12:36:32Z

app/modules/c3coding_arduino.js

+        this.handler = handler;
+        this.config = config;
+    }
+    setSerialPort = function (sp) {


⚠️ [eslint] <space-before-function-paren> _{reported by reviewdog 🐶}
Unexpected space before function parentheses.

Suggested change

setSerialPort = function (sp) {

setSerialPort = function(sp) {

github-actions · 2023-12-23T12:36:32Z

app/modules/c3coding_arduino.js

+        this.config = config;
+    }
+    setSerialPort = function (sp) {
+        var self = this;


⚠️ [eslint] <no-var> _{reported by reviewdog 🐶}
Unexpected var, use let or const instead.

Suggested change

var self = this;

let self = this;

github-actions · 2023-12-23T12:36:33Z

app/modules/c3coding_arduino.js

+        this.sp = sp;
+    };
+    // 연결 후 초기에 송신할 데이터가 필요한 경우 사용합니다.(필수)
+    requestInitialData = function () {


⚠️ [eslint] <space-before-function-paren> _{reported by reviewdog 🐶}
Unexpected space before function parentheses.

Suggested change

requestInitialData = function () {

requestInitialData = function() {

github-actions · 2023-12-23T12:36:33Z

app/modules/c3coding_arduino.js

+        return this.makeSensorReadBuffer(this.sensorTypes.ANALOG, 0);
+    };
+    // 연결 후 초기에 수신받아서 정상연결인지를 확인해야하는 경우 사용합니다.(필수)
+    checkInitialData = function (data, config) {


⚠️ [eslint] <space-before-function-paren> _{reported by reviewdog 🐶}
Unexpected space before function parentheses.

Suggested change

checkInitialData = function (data, config) {

checkInitialData = function(data, config) {

github-actions · 2023-12-23T12:36:34Z

app/modules/c3coding_arduino.js

+                    }
+                } else if (Array.isArray(dataObj.port)) {
+                    isSend = dataObj.port.every(function (port) {
+                        var time = self.digitalPortTimeList[port];


⚠️ [eslint] <no-var> _{reported by reviewdog 🐶}
Unexpected var, use let or const instead.

Suggested change

var time = self.digitalPortTimeList[port];

let time = self.digitalPortTimeList[port];

github-actions · 2023-12-23T12:36:34Z

app/modules/c3coding_arduino.js

+                    });
+
+                    if (isSend) {
+                        dataObj.port.forEach(function (port) {


⚠️ [eslint] <prefer-arrow-callback> _{reported by reviewdog 🐶}
Unexpected function expression.

Suggested change

dataObj.port.forEach(function (port) {

dataObj.port.forEach((port) => {

github-actions · 2023-12-23T12:36:34Z

app/modules/c3coding_arduino.js

+                    });
+
+                    if (isSend) {
+                        dataObj.port.forEach(function (port) {


⚠️ [eslint] <space-before-function-paren> _{reported by reviewdog 🐶}
Unexpected space before function parentheses.

Suggested change

dataObj.port.forEach(function (port) {

dataObj.port.forEach(function(port) {

github-actions · 2023-12-23T12:36:35Z

app/modules/c3coding_arduino.js

+                            self.makeSensorReadBuffer(
+                                key,
+                                dataObj.port,
+                                dataObj.data


⚠️ [eslint] <comma-dangle> _{reported by reviewdog 🐶}
Missing trailing comma.

Suggested change

dataObj.data

dataObj.data,

github-actions · 2023-12-23T12:36:35Z

app/modules/c3coding_arduino.js

+        }
+
+        if (setDatas) {
+            var setKeys = Object.keys(setDatas);


⚠️ [eslint] <no-var> _{reported by reviewdog 🐶}
Unexpected var, use let or const instead.

Suggested change

var setKeys = Object.keys(setDatas);

let setKeys = Object.keys(setDatas);

kkongnamul11 and others added 15 commits November 30, 2023 00:37

HEXA BOARD 최초 커밋

2280a65

씨큐브코딩 최초 커밋

a918b46

Merge pull request #694 from dkgkejdrb/develop-hw

456edd3

씨큐브코딩 최초 커밋

fix: 센서우노 port autoSelect 오류 수정

00ea2c3

펌웨어 추가 커밋

f493ff4

Merge pull request #695 from dkgkejdrb/develop-hw

c093be7

펌웨어 추가 커밋

selectport true

f7876a1

Update aiot.json

88bdc0a

Update aiot.png

5a5d231

Change aiot image file via upload

69a1d7c

Merge pull request #692 from makeitnow-company/develop-hw

9c7cf49

HEXA BOARD 최초 커밋

Merge pull request #697 from jdlee0320/develop-hw

2145f9a

AIoT HW 변경

Merge pull request #696 from kagnesyun/develop-hw

554d699

selectport true

chore: aiot 이메일 추가

09c007a

chore: 버전업 1.9.49

d5d7629

Tnks2U self-assigned this Dec 23, 2023

Tnks2U merged commit 1125816 into master Dec 23, 2023
1 check passed

github-actions bot reviewed Dec 23, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[1.9.49] 버전업 PR #698

[1.9.49] 버전업 PR #698

Tnks2U commented Dec 23, 2023

github-actions bot left a comment

github-actions bot Dec 23, 2023

github-actions bot Dec 23, 2023

github-actions bot Dec 23, 2023

github-actions bot Dec 23, 2023

github-actions bot Dec 23, 2023

github-actions bot Dec 23, 2023

github-actions bot Dec 23, 2023

github-actions bot Dec 23, 2023

github-actions bot Dec 23, 2023

github-actions bot Dec 23, 2023

		@@ -0,0 +1,451 @@
		const BaseModule = require('./baseModule');

		class c3coding_arduino extends BaseModule {

	setSerialPort = function (sp) {
	setSerialPort = function(sp) {

	requestInitialData = function () {
	requestInitialData = function() {

	checkInitialData = function (data, config) {
	checkInitialData = function(data, config) {

	var time = self.digitalPortTimeList[port];
	let time = self.digitalPortTimeList[port];

	dataObj.port.forEach(function (port) {
	dataObj.port.forEach((port) => {

	dataObj.port.forEach(function (port) {
	dataObj.port.forEach(function(port) {

	var setKeys = Object.keys(setDatas);
	let setKeys = Object.keys(setDatas);

[1.9.49] 버전업 PR #698

[1.9.49] 버전업 PR #698

Conversation

Tnks2U commented Dec 23, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 23, 2023

Choose a reason for hiding this comment

github-actions bot Dec 23, 2023

Choose a reason for hiding this comment

github-actions bot Dec 23, 2023

Choose a reason for hiding this comment

github-actions bot Dec 23, 2023

Choose a reason for hiding this comment

github-actions bot Dec 23, 2023

Choose a reason for hiding this comment

github-actions bot Dec 23, 2023

Choose a reason for hiding this comment

github-actions bot Dec 23, 2023

Choose a reason for hiding this comment

github-actions bot Dec 23, 2023

Choose a reason for hiding this comment

github-actions bot Dec 23, 2023

Choose a reason for hiding this comment

github-actions bot Dec 23, 2023

Choose a reason for hiding this comment