Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NayNay] Install Issue #430

Merged
merged 3 commits into from
Nov 6, 2024
Merged

[NayNay] Install Issue #430

merged 3 commits into from
Nov 6, 2024

Conversation

rh0delta
Copy link
Contributor

@rh0delta rh0delta commented Nov 5, 2024 •
edited by mixmix
Loading

Related Issue(s)

Proposed Changes

  • removed postinstall script from package json
  • hindering our users from installing the CLI through npm

@rh0delta
[NayNay] Install Issue
7d8bb31 
- removed postinstall script from package json
- hindering our users from installing the CLI through npm
@mixmix
Copy link
Collaborator

mixmix commented Nov 5, 2024 •
edited
Loading

I'm researching this

@mixmix
Copy link
Collaborator

mixmix commented Nov 5, 2024

Summary of discussion on call

  1. The CLI needs a bundled version which has patched polkadot
  2. The patching should happen
    • before SDK test script
    • before CLI test script
    • before CLI build srcript
    • NOT on CLI global install

Decision

rip out patch-package trying this

@mixmix
Copy link
Collaborator

mixmix commented Nov 6, 2024

Logs look chill. I'm merging this

@mixmix mixmix merged commit 55ce49a into main Nov 6, 2024
3 checks passed
@mixmix mixmix deleted the naynay/husky-issue branch November 6, 2024 00:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mixmix mixmix mixmix approved these changes

@frankiebee frankiebee Awaiting requested review from frankiebee frankiebee is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting NPM install errors when trying to install the CLI.
2 participants
@rh0delta @mixmix