[NayNay] Sign takes a verifying key now #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated sign methods to take a verifying key as an argument and use it to overwrite the keyring verifying key if needed
|
still in draft state, need to add tests |
|
@mixmix review |
mixmix
requested changes
Jun 18, 2024
mixmix
reviewed
Jun 18, 2024
rh0delta
force-pushed
the
naynay/sign-verifying-keys
branch
from
6ff973c
to
b04831c
Compare
|
@mixmix / @frankiebee this PR is ready for re-review |
mixmix
reviewed
Jun 19, 2024
rh0delta
commented
Jun 20, 2024
frankiebee
requested changes
Jun 20, 2024
Co-authored-by: Frankie <[email protected]>
…tropy-js into naynay/sign-verifying-keys
mixmix
reviewed
Jun 24, 2024
rh0delta
commented
Jun 24, 2024
…tropy-js into naynay/sign-verifying-keys
mixmix
previously approved these changes
Jun 24, 2024
|
NOTE: if it passes after that .... we have intermittent tests |
Merged
rh0delta
added a commit
that referenced
this pull request
Jul 11, 2024
## [0.2.2] Bathala - 2024-07-11 (entropy-core compatibility: 0.2.0) ### Added - now exports utils [395](#395) - now exports testing environments from /dev [393](https://github.com/entropyxyz/sdk/pull/393/files) ### Fixed - hot fix for issue #380: try in reverse order for testnet environment - `entropy.signingManager.getTimeStamp` -> `entropy.signingManager.getBlockNumber` signature request no longer takes a time stamp and now takes a block number. [396](#396) ### Changed - constructor now throws if you pass no object - sign now takes a verifying key [382](#382)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GitHub Issue or Linear Task
closes entropyxyz/cli#113
How Has This Been Tested?