Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference docs generation and plan. #319

Merged
merged 55 commits into from
Jun 25, 2024
Merged

Reference docs generation and plan. #319

merged 55 commits into from
Jun 25, 2024

Conversation

mixmix
Copy link
Collaborator

@mixmix mixmix commented Apr 18, 2024

mega PR for us to jam on till it's done (as discussed with Frankie)

The aim of this PR is to :

  • makes README.md a chill into + link out to further resources
  • build docs/ into a rich website

What the website will look like:

image

@mixmix mixmix marked this pull request as draft April 18, 2024 04:19
@mixmix mixmix changed the base branch from main to code-style April 30, 2024 03:13
package.json Show resolved Hide resolved
@@ -107,3 +113,5 @@ export default class ExtrinsicBaseClass {
return freeTxWrapper
}
}

export default ExtrinsicBaseClass
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change was needed to preserve the names of exports in docs 🤷

@mixmix mixmix requested a review from rh0delta as a code owner June 6, 2024 04:22
@mixmix
Copy link
Collaborator Author

mixmix commented Jun 6, 2024

@frankiebee / @rh0delta this is ready for a review.
I through out a lot of stuff and have just kept the "docs building" piece which makes HTML site which @johnnymatthews will presumably integrate at some place??

One thing we need to decide is what we want that site to look like. Currently that ugly HTML page has an ... on site map nested thing on the left but it's ... awkwardly named. Like it doesn't line up with what we export from the package.json 🤮 So ... do we care/ wanna fix it? I've looked into typedoc config and can't find a nicer way of renaming those other than "move all the files" ... I think we might need to discuss "design" around what we export and why?

@johnnymatthews
Copy link
Contributor

Ideally, if there's a way to spit out this stuff into regular old markdown files, then we can port it over to the main docs repo. Is that even a thing we can do?

@mixmix
Copy link
Collaborator Author

mixmix commented Jun 10, 2024

Decision: we need to have a documentation meeting
@johnnymatthews can you come up with a proposal about how we're doing docs this / next week?

@mixmix
Copy link
Collaborator Author

mixmix commented Jun 10, 2024

@frankiebee please review

@johnnymatthews johnnymatthews changed the title [EPIC] docs Reference docs plan. Jun 10, 2024
@johnnymatthews johnnymatthews changed the title Reference docs plan. Reference docs generation and plan. Jun 10, 2024
@johnnymatthews johnnymatthews added the documentation Improvements or additions to documentation label Jun 10, 2024
@johnnymatthews
Copy link
Contributor

Created a relevant issue for planning over in Docs: entropyxyz/entropy-docs#121

@mixmix
Copy link
Collaborator Author

mixmix commented Jun 17, 2024

@johnnymatthews can we merge this?

@mixmix
Copy link
Collaborator Author

mixmix commented Jun 18, 2024

Found a plugin which makes the entry points (sections on left) less of a mess

Also started adding some @examples to make it a lot clearer how to import / use some of these pieces

image

@mixmix
Copy link
Collaborator Author

mixmix commented Jun 23, 2024

Hey I want this PR merged or closed this week.
@johnnymatthews I propose we merge as is, and set up Github generation of static site. We can change it later if we want

- `main`
"stable" what is on npm

- `<name>/<issue_number>-<short_title>` (personal branches)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is issue number required for the branch name? Will this now be the new standard? More often than not, our branches don't include the issue number in the name, but rather required in the PR description prefixed by "closes" or "fixes" or something along those lines

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I copied this from notes from a call with frankie. I'm not sure I care about issue number.
Let's discuss

- `<name>/<issue_number>-<short_title>` (personal branches)
for example `frankie/i123-docs`

all PRS go into `dev`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make a comment about hotfix prs going straight to main?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. Those would be patch releases aye?

i feel like we could make a patch branch. Basically anything we write ha gotta get smoke testing befor going into main + published...

depends how many patches we expect. What I'm being cautious of is "special shorcuts". They can cause problems


The SDK version must match a compatible [`entropy-core`](https://github.com/entropyxyz/entropy-core) version.

<!-- TODO: -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this here for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An invisible comment!

i think I'd like to see a thing there where we list the details of the compatible versions of things.

this was just from using other sdks where it became a nightmare to know how to run a compatible network of tools cos the versions of things which work together was not well documented.
i may have trauma

frankiebee
frankiebee previously approved these changes Jun 25, 2024
@frankiebee frankiebee merged commit d671a67 into main Jun 25, 2024
1 check passed
@frankiebee frankiebee deleted the mixmix/DOCS branch June 25, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants