Skip to content

Example: Dining cryptographers #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 55 commits into from
Jun 6, 2025
Merged

Example: Dining cryptographers #102

merged 55 commits into from
Jun 6, 2025

Conversation

dvdplm
Copy link
Collaborator

@dvdplm dvdplm commented May 12, 2025

Implement Dining cryptographers problem in manul, as an example of a non-trivial protocol.

  • Implement the example
  • Random documentation tweaks outside the example proper
  • A "guide" level document thought to be an intro to manul. Probably needs more/better material but it's a start.
  • Where should it live?
  • Should it perhaps be a part of the crate docs?
  • Should I remove it and make into a separate PR?

Questions

  • There are plenty of questions in the code
  • How should we run examples? In this PR I suggest using [[bin]] in the manul-examples cargo file so users can run with cargo run, but open to other suggestions.
  • Does this example complement the existing ones or does it replace them (in part, in full)?
  • Do we need more examples or is this enough for now?

@coveralls

This comment was marked as off-topic.

@fjarri
Copy link
Member

fjarri commented Jun 6, 2025

The code looks good to me, but I'm still not convinced about the directory layout. It looks weird, especially next to the other example which is a library. Are you sure this makes it easier to understand as opposed to it being in src/? It would still be a single file, just main() would be a test.

@fjarri
Copy link
Member

fjarri commented Jun 6, 2025

Just realized there's #115. I guess this'll go in then, but I do hope we clean it up soon (famous last words, I know).

@fjarri fjarri merged commit 46fe191 into master Jun 6, 2025
8 checks passed
@fjarri fjarri deleted the dp-dining-cryptographers branch June 6, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants