-
Notifications
You must be signed in to change notification settings - Fork 4
Fix for release v0.4.0 #1432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/v0.4.0
Are you sure you want to change the base?
Fix for release v0.4.0 #1432
Conversation
…-tss` (#1385) * Repeatedly make backup attempts when starting entropy-tss * Add additional test to show that requesting backup will work when the backup provider is not immediately available * Clippy
* Apply fix suggested by Zach * Add check for the first commit of a branch * remove GITHUB_ENV redirect to simplify job --------- Co-authored-by: Zach Mandeville <[email protected]>
* Clippy - chain node * Clippy - TSS
Oh dear it seems there is an issue when running entropy on this branch. I also get this problem locally -
|
I made an issue for this: #1435 - it seems to be unrelated to the release or the fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know the build is broken, but code looks fine otherwise.
One Q, for a0dbc7c is that something that's fixed on master
already?
Yes, but the fix is in Jesse's update substrate PR and i don't want to include that here |
This cherry-picks commit
1634692c
, adding the fix from PR #1385 to release v0.4.0-rc1I tried releasing directly from that commit and had issues, even though the changed in-between are mostly just minor version bumps from dependabot - but to be sure i want to check CI passes here before releasing on this branch.
To get CI to run i also needed this: #1410 so i cherry picked that as well.