Skip to content

Fix for release v0.4.0 #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: release/v0.4.0
Choose a base branch
from
Open

Conversation

ameba23
Copy link
Collaborator

@ameba23 ameba23 commented May 16, 2025

This cherry-picks commit 1634692c, adding the fix from PR #1385 to release v0.4.0-rc1

I tried releasing directly from that commit and had issues, even though the changed in-between are mostly just minor version bumps from dependabot - but to be sure i want to check CI passes here before releasing on this branch.

To get CI to run i also needed this: #1410 so i cherry picked that as well.

ameba23 and others added 5 commits May 16, 2025 09:27
…-tss` (#1385)

* Repeatedly make backup attempts when starting entropy-tss

* Add additional test to show that requesting backup will work when the backup provider is not immediately available

* Clippy
* Apply fix suggested by Zach

* Add check for the first commit of a branch

* remove GITHUB_ENV redirect to simplify job

---------

Co-authored-by: Zach Mandeville <[email protected]>
* Clippy - chain node

* Clippy - TSS
@ameba23
Copy link
Collaborator Author

ameba23 commented May 16, 2025

Oh dear it seems there is an issue when running entropy on this branch. I also get this problem locally - entropy will compile successfully but on running it i get:

/target/release/entropy --dev
2025-05-16 10:52:59 Entropy Node
2025-05-16 10:52:59 ✌️  version 0.4.0-rc.1-unknown
2025-05-16 10:52:59 ❤️  by Entropy Cryptography <[email protected]>, 2022-2025
2025-05-16 10:52:59 📋 Chain specification: Development
2025-05-16 10:52:59 🏷  Node name: obsequious-degree-1366
2025-05-16 10:52:59 👤 Role: AUTHORITY
2025-05-16 10:52:59 💾 Database: RocksDb at /tmp/pumkin/substrate7TiH01/chains/dev/db/full
2025-05-16 10:53:01 [0] 💸 generated 4 npos voters, 4 from validators and 0 nominators
2025-05-16 10:53:01 [0] 💸 generated 4 npos targets
Error: Service(Client(VersionInvalid("Other error happened while constructing the runtime: runtime requires function imports which are not present on the host: 'env:_RNvCscSpY9Juk0HT_7___rustc17rust_begin_unwind'")))
2025-05-16 10:53:02 Cannot create a runtime error=Other("runtime requires function imports which are not present on the host: 'env:_RNvCscSpY9Juk0HT_7___rustc17rust_begin_unwind'")

@ameba23
Copy link
Collaborator Author

ameba23 commented May 16, 2025

I made an issue for this: #1435 - it seems to be unrelated to the release or the fix

Copy link
Collaborator

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the build is broken, but code looks fine otherwise.

One Q, for a0dbc7c is that something that's fixed on master already?

@ameba23
Copy link
Collaborator Author

ameba23 commented May 16, 2025

One Q, for a0dbc7c is that something that's fixed on master already?

Yes, but the fix is in Jesse's update substrate PR and i don't want to include that here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants