BoxedUint support
#40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjarri
force-pushed
the
boxed-support
branch
from
ba18980
to
fc1467b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 99.20% 99.23% +0.02%
==========================================
Files 9 9
Lines 1386 1433 +47
==========================================
+ Hits 1375 1422 +47
Misses 11 11 ☔ View full report in Codecov by Sentry. |
|
@tarcieri I think this concludes the initial support stage for |
fjarri
force-pushed
the
boxed-support
branch
from
fc1467b
to
899c81c
Compare
fjarri
force-pushed
the
boxed-support
branch
from
899c81c
to
f9f673d
Compare
fjarri
force-pushed
the
boxed-support
branch
from
f9f673d
to
b86c990
Compare
fjarri
force-pushed
the
boxed-support
branch
from
24444fb
to
2b44a1f
Compare
|
Published v0.6.0-pre.0. Before 0.6.0 proper I may tweak the public API a little with respect to how Also filed #41 to investigate the BoxedUint performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may supersede #39. It uses
*_likeconstructors (see RustCrypto/crypto-bigint#533) instead of automatic widening, which I think is a safer approach.The 1024 bit safe prime generation is about 30% slower for
BoxedUintcompared toUint. Not too bad for a start, but clearly there is room for improvement.@xuganyu96 sorry, tried to base it on your PR, but I guess I changed the first commit too much, and it's not assigned to you anymore.