Common tracing and retry/backoff support for go-gather #1993
Conversation
zregvart
force-pushed
the
pr/go-gather-tracing-retry-backoff
branch
from
9ff2ed0 to
d6089a2
Compare
Adds a `internal/http` package that can be used to configure HTTP clients with the default tracing, retry and backoff configuration. The configuration is applied to the internal OCI client abstraction for use in go-containerregistry.
Applies the common HTTP tracing, retry and backoff configuration to OCI and HTTP go-gather implementations.
Updates HTTP and OCI modules of go-gather.
zregvart
force-pushed
the
pr/go-gather-tracing-retry-backoff
branch
from
d6089a2 to
0cc70f2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1993 +/- ##
==========================================
+ Coverage 74.05% 74.25% +0.20%
==========================================
Files 87 88 +1
Lines 5716 5742 +26
==========================================
+ Hits 4233 4264 +31
+ Misses 1483 1478 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
|
||
| var _initialize = func() { | ||
| if log.IsLevelEnabled(logrus.TraceLevel) { | ||
| goci.Transport = http.NewTracingRoundTripperWithLogger(goci.Transport, log) |
There was a problem hiding this comment.
As a follow up, we should use a solution that doesn't rely on global states. Besides being a safer approach it would also remove the need to use sync. I understand that that would require changes in go-gather itself. Could you file a follow up issue?
There was a problem hiding this comment.
| return gather.Gather(ctx, source, destination) | ||
| } | ||
|
|
||
| var _initialize = func() { |
There was a problem hiding this comment.
Could this be done during init to avoid having to use sync.OnceFunc?
There was a problem hiding this comment.
Could not control it in tests then
More details in the commit messages. Adds a set of common variables used to configure the HTTP clients used by go-containerregistry and go-gather HTTP and OCI support via ORAS.
Requires enterprise-contract/go-gather#114 and enterprise-contract/go-gather#113 to be merged and versions to be bumped here.