Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Support for storing preview files #4226

Merged
merged 33 commits into from
Dec 19, 2024
Merged

[server] Support for storing preview files #4226

merged 33 commits into from
Dec 19, 2024

Conversation

ua741
Copy link
Member

@ua741 ua741 commented Nov 28, 2024

Description

  • This change introduced the concept of associated object for a file.
  • Added additional columns for object_id, object_nonce, and object_size.

Depending upon data_type, the values of certain columns will be nil.
The original size column will reflect total size for that particular type. In case of vid_preview, it's size of the playlist + size of the preview video.

Tests

  • Replication
  • Test Deletion post replication

Copy link
Member

@mnvr mnvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments on some trivial typos etc, also the file render.svg seems unrelated to this PR.

server/ente/filedata/path.go Outdated Show resolved Hide resolved
server/ente/filedata/video.go Outdated Show resolved Hide resolved
@ua741 ua741 marked this pull request as ready for review December 18, 2024 07:50
@ua741 ua741 merged commit 2a4a886 into main Dec 19, 2024
2 checks passed
@ua741 ua741 deleted the video_file_preview branch December 19, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants