fix: universalresolver hybrid onchain/offchain handling #324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, a batch call would add non-ENSIP10 encoded calls to
extraDatas
for onchain calls.extraDatas
is used withinOffchainLookup
, and is directly passed through from a call to a callback, allowing the UR to re-call requests that were already onchain. since the calls inextraDatas
were not ENSIP10 encoded, and since calls are not re-encoded in callbacks, this lead to situations where for a hybrid (onchain/offchain calls together) batch call, onchain data would be fetched on callback with the non-ENSIP10 equivalent function.changes:
extraDatas
to be the potentially ENSIP10 encoded item._checkResolveSingle()
inreverseCallback()