Add check to prevent people from using the resolver without owner

ensdomains · Oct 30, 2023 · cb56a0b · cb56a0b
1 parent e03e212
commit cb56a0b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/contracts/resolvers/DelegatableResolver.sol b/contracts/resolvers/DelegatableResolver.sol
@@ -102,6 +102,7 @@ contract DelegatableResolver is
      * @return address The owner address
      */
     function owner() public view returns (address) {
+        require(_getArgAddress(0) != address(0), "Owner is not set");
         return _getArgAddress(0);
     }
 

diff --git a/test/resolvers/TestDelegatableResolver.js b/test/resolvers/TestDelegatableResolver.js
@@ -64,6 +64,10 @@ contract('DelegatableResolver', function (accounts) {
   })
 
   describe('factory', async () => {
+    it('owner must be set', async () => {
+      await expect(impl.owner()).to.be.revertedWith('Owner is not set')
+    })
+
     it('predicts address', async () => {
       const tx = await factory.createClone2(operator)
       const result = tx.logs[0].args.resolver