Merge pull request #294 from lcfr-eth/staging

Minor QA things
ensdomains · Dec 5, 2023 · 5ae0cd7 · 5ae0cd7
2 parents e08a9b3 + 4654f35
commit 5ae0cd7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/contracts/ethregistrar/ETHRegistrarController.sol b/contracts/ethregistrar/ETHRegistrarController.sol
@@ -20,6 +20,7 @@ error CommitmentTooOld(bytes32 commitment);
 error NameNotAvailable(string name);
 error DurationTooShort(uint256 duration);
 error ResolverRequiredWhenDataSupplied();
+error ResolverRequiredWhenReverseRecord();
 error UnexpiredCommitmentExists(bytes32 commitment);
 error InsufficientValue();
 error Unauthorised(bytes32 node);
@@ -120,6 +121,9 @@ contract ETHRegistrarController is
         uint16 ownerControlledFuses
     ) public pure override returns (bytes32) {
         bytes32 label = keccak256(bytes(name));
+        if (resolver == address(0) && reverseRecord == true) {
+            revert ResolverRequiredWhenReverseRecord();
+        }
         if (data.length > 0 && resolver == address(0)) {
             revert ResolverRequiredWhenDataSupplied();
         }

diff --git a/contracts/ethregistrar/IETHRegistrarController.sol b/contracts/ethregistrar/IETHRegistrarController.sol
@@ -24,6 +24,8 @@ interface IETHRegistrarController {
 
     function commit(bytes32) external;
 
+    function commitments(bytes32) external view returns (uint256);
+
     function register(
         string calldata,
         address,