Json exercise saigo #132
Open
Json exercise saigo #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokpro
reviewed
Dec 7, 2018
There was a problem hiding this comment.
@kav121988 good version 1 👍
Please look at few of my comments below -
| Name string `json:"name"` | ||
| Age int `json:"age"` | ||
| ImageUrl string `json:"imageUrl"` | ||
| ID string `json:"id"` |
There was a problem hiding this comment.
run go fmt -w ./... before pushing the commit. It fixes all the formatting issues.
| ) | ||
|
|
||
| // Phone ... | ||
| type Phone struct { | ||
| Name string `json:"name"` | ||
| Name string `json:"name"` |
There was a problem hiding this comment.
You can skip json:... when:
- It's a single world variable (i.e. name -> Name will be automated)
- JSON key is already camel case (imageUrl - > ImageUrl)
| } | ||
|
|
||
| var allPhones []Phone | ||
|
|
||
| func setup() { | ||
| data, err := ioutil.ReadFile("phones.json") | ||
| func PanicOn(err error) { |
There was a problem hiding this comment.
Generally, it's good idea to create functions for repeated structures. But, go error statements are exceptions.
It's pretty common to see code like -
resp, err := func1()
if err != nil {
panic(err)
}
resp2, err := func2(resp)
if err != nil {
logToSentry()
panic(err)
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.