Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soc.py: ethernet: use phy_cd name from phy #2163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maass-hamburg
Copy link
Contributor

use phy_cd name directly from phy.

Signed-off-by: Fin Maaß [email protected]

use phy_cd name directly from phy.

Signed-off-by: Fin Maaß <[email protected]>
@enjoy-digital
Copy link
Owner

Thanks @maass-hamburg, would you mind describing the context/use-case to think about it and review it with this in mind?

@maass-hamburg
Copy link
Contributor Author

It uses the same logic, as the part a little bit under it at with_timing_constraints, to get the phy names. This can be very useful, when you want to use than one phy (multiple instances), specificly when each phy has its own ClockDomains, like here: enjoy-digital/liteeth#181. There I numbered the ClockDomain Names, so they would not replace each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants