Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor where starter project version is determined #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

macdonst
Copy link
Contributor

@macdonst macdonst commented May 31, 2023

In order to be able to re-use this code in the Begin CLI I needed to refactor where we determine the starter project version. Taking it out of create project allows me to build a CJS version of that file that can be used in the Begin CLI.

Signed-off-by: macdonst [email protected]

@kristoferjoseph
Copy link
Contributor

Thanks for looking into this!

I didn't get a chance to comment on this but I was hoping that this version magic would use a semver parser and not be a hardcoded by hand number.

The intent was to just keep from upgrading users to a breaking change.

Was this already resolved upstream?
Did you think through a scenario I missed where we actually do want to hard code this by hand?

@macdonst
Copy link
Contributor Author

macdonst commented Jun 7, 2023

@kristoferjoseph I can change this to a semver. I stayed away from that initially in order to not add another dependency to this project. Let's talk about the way it works in Enhance Sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants