-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create player component video-moq
#10
Comments
I really like this idea. (See: #4 (comment)) Thanks for writing it up! |
Working on this btw! |
…is commit should be reverted before merging.
Opened a draft PR here. Open for suggestions/corrections |
…diaElement naming
…them to dom if no attribute is present. Added mute attribute like in <video> tag
… namespace and fingerprint as attributes or have them included as query params in the src attribute
… present as an attirubte. Also renamed variables to #element
…atch tsx. Style tbd
Opened the PR so we can merge what we have now and keep working from there (Anyone feel free to review). I see there are some new features to be merged which we should include in the web component. There is also some other work to be done listed in the PR which did not seem worth it to delay the merge for. I'll be writing up some new issues with these points |
Note from our meeting: This can be the starting point for a samples page like the dash.js one |
Merged in #16 |
Following the idea of issue #4, to decouple the player from the web application and improve modularity, we can create a WebComponent for the player. This approach ensures the player is fully encapsulated, making it reusable across different web pages and projects without dependencies on the current application structure.
In my mind the WebComponent
<video-moq></video-moq>
should implement and follow same logic of the classic<video>
tag, may be in a first iteration we can focus in implement the most important ones.From a user perspective I would imagine using the component like this (insipred in hls.js):
Basic Usage
Advanced Usage
List of attributes to implement
Taken from <video>: The Video Embed element.
src
width
height
controls
autoplay
muted
poster
Possible implementation
The new WebComponent
<video-moq>
will render the canvas element to display de video and in the future with #7 we can overlay the controls if the attribute is set. For this we can reuse the whole library implemented here to control the video itself, so importing the script of the player will result in having the<video-moq>
component andMoqPlayer
class for advaced usaged exported.The text was updated successfully, but these errors were encountered: