Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor repo structure to keep the player as a main component #11

Closed
emilsas opened this issue Nov 28, 2024 · 4 comments
Closed

Refactor repo structure to keep the player as a main component #11

emilsas opened this issue Nov 28, 2024 · 4 comments

Comments

@emilsas
Copy link

emilsas commented Nov 28, 2024

Following the idea of issue #4, if we want to follow the approach of keeping this repo as the moq player, I will propose refactoring this repo to keep the source code of the component #10 as the main source and moving the web page to a samples directory.

@englishm
Copy link
Owner

englishm commented Dec 3, 2024

FYI, we can outright delete most of the website in this repo and start from scratch with vanilla HTML + JS demos, if we want. In fact, I'd prefer that, really. Maybe I'll flesh out a new demo site at some point in the future, but I don't feel the need to keep any of the quic.video content here. So feel free to delete rather than moving stuff here. This can also be an opportunity to revisit any of the packaging build release tooling since I think that's currently tied to building the quic.video Vite site and all that entails.

@englishm
Copy link
Owner

englishm commented Dec 3, 2024

Also, see #4 (comment) for some previous work towards teasing things apart. I think just cutting out the website altogether might really simplify this process.

@nicolaslevy
Copy link
Collaborator

@emilsas after the PR #13 the player is under the "lib" folder and there are two examples "web" and "web simple". After this refactor, should we cose this issue?

@emilsas
Copy link
Author

emilsas commented Jan 13, 2025

Good! Closing it...

@emilsas emilsas closed this as completed Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants