Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix job cleanup evasion vulnerability, improve job execution error handling #624

Merged
merged 3 commits into from
Oct 8, 2023
Merged

Fix job cleanup evasion vulnerability, improve job execution error handling #624

merged 3 commits into from
Oct 8, 2023

Commits on Sep 15, 2023

  1. Improve normal execution error handling 

    - Properly differentiate between bad requests and internal server errors
- Avoid clean up evasion by putting the cleanup in the finally block
    @Brikaa
    Brikaa committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    fe2fc37 View commit details
    Browse the repository at this point in the history

  2. Interactive execution: run job cleanup regardless of errors

    @Brikaa
    Brikaa committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    040e19f View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2023

  1. Comments explaining the try-catch flow

    @Brikaa
    Brikaa committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    6a47869 View commit details
    Browse the repository at this point in the history