-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new and pre-release Java builds #600
base: master
Are you sure you want to change the base?
Conversation
Also, huge apologies if they don't build. I see the other github issue where the person didn't build them locally and that was bad, but I have an M1 mac so the docker images actually don't work on my machine. I would likely have to use the workflow here to validate unfortunately :( |
Good news! got a linux laptop to test all of this and they did build with some changes Bad news! The entire reason i want to have these ea builds is moot since the change hasnt been merged in yet. Kindof a bummer, but it will come out eventually and the central question of "would the piston folks be okay adding pre-release java builds to the public api/built in set" is still worth figuring out/for me |
@@ -0,0 +1,5 @@ | |||
{ | |||
"language": "java", | |||
"version": "20.valhalla.20.75", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how semver compliant this version number is
I ended up giving up waiting for this and forked the rust playground to do what I wanted. https://java-playground.com I'll leave the issue up in case anyone else is still interested, but i've moved on. |
The reason I want 21-ea specifically is so that I can have my book run code snippets using anonymains
https://openjdk.org/jeps/445