-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor Script to convert TMP to RTLTMP #1
Conversation
Also can convert Text to RTLTMP
} | ||
|
||
/// <summary> | ||
/// Unfortunately I'm not sure how to do GUID swapping, so references to the text component will break, but at least it should make the transition much safer and quicker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this asset handled the conversion to TMPro without losing references. Breaking existing references is not an option, there are thousands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not what this asset does. We've already handled that in https://github.com/engage-xr/Engage_Main/pull/2004
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do raise a valid point though, if we go from TMP -> RTLTMP we would still potentially lose some references.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant references in other components, #2004 only handled references in code, but not from other non-code components.
Closing this as we can handle it from the New UI Widgets converter by changing the type it goes to to be RTLTMPro |
Also can convert Text to RTLTMP.
Taken from a PR from the base repo: pnarimani#114