Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add decentralized-web-node app #57

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Harasz
Copy link
Contributor

@Harasz Harasz commented Apr 25, 2022

No description provided.

@Harasz Harasz requested a review from jrhender April 25, 2022 16:29
@Harasz Harasz force-pushed the task/ICS-203-add-dwn branch 2 times, most recently from fa7844d to 4fa375d Compare April 27, 2022 15:12
@Harasz Harasz marked this pull request as ready for review April 27, 2022 17:33
@Harasz
Copy link
Contributor Author

Harasz commented Apr 27, 2022

@jrhender I think PR is ready for review

@jrhender
Copy link
Collaborator

Thanks, I will take a look today

@jrhender
Copy link
Collaborator

Looks good, thanks for this @Harasz . Any idea why the tests are failing though? I took a quick look and it didn't jump out at me.

@Harasz
Copy link
Contributor Author

Harasz commented Apr 29, 2022

@jrhender I have no idea, problem is not with DWN test but in @energyweb/ssi-vc-api test file. I see those two tests scenerios ale failing App (e2e) › Rebeam (e2e) › should throw an error when presentation definition contain more then one 'credentialQuery' item,
App (e2e) › Rebeam (e2e) › Rebeam presentation using ed25119 signatures are failing.

Problem is the same

TypeError: Converting circular structure to JSON
        --> starting at object with constructor 'OverriddenClientRequest'
        --- property 'req' closes the circle
        at JSON.stringify (<anonymous>)

      105 |       const body = TransactionDto.toDto(transaction);
      106 |       this.httpService.post(callback.url, body).subscribe({
    > 107 |         next: (v) => Logger.log(v),
          |                             ^
      108 |         error: Logger.error
      109 |       });
      110 |     });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants