Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Cheese from mandatory apps #149

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

wjt
Copy link
Member

@wjt wjt commented Jan 18, 2024

Cheese was moved from the OS to a Flatpak in eos4.0. There has been a checkpoint between eos4.0 and eos5.0+, so we can now remove the flatpak-autoinstall.d rule that requires it to be installed. It follows that we can relegate it to "default" status, which in particular means that base images need no longer include it.

Depends on:

https://phabricator.endlessm.com/T35175

Cheese was moved from the OS to a Flatpak in eos4.0. There has been a
checkpoint between eos4.0 and eos5.0+, so we can now remove the
flatpak-autoinstall.d rule that requires it to be installed. It follows
that we can relegate it to "default" status, which in particular means
that base images need no longer include it.

https://phabricator.endlessm.com/T35175
Copy link
Contributor

@manuq manuq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so "apps_add_mandatory" apps are going to the base image, and "apps_add" go to default images like GIMP, Godot, etc.

@manuq manuq merged commit 78db063 into master Jan 18, 2024
2 checks passed
@manuq manuq deleted the T35175-lactose-intolerance branch January 18, 2024 15:35
@wjt wjt requested a review from cassidyjames January 18, 2024 15:38
@wjt
Copy link
Member Author

wjt commented Jan 18, 2024

I see, so "apps_add_mandatory" apps are going to the base image, and "apps_add" go to default images like GIMP, Godot, etc.

The way it works is that base.ini uses the ${apps_add_defaults} list in its apps_del key for each remote.

https://github.com/endlessm/eos-image-builder/blob/master/config/personality/base.ini#L8-L14

The image builder adds up all the apps_add* keys for a remote, then subtracts all the apps_del* keys for that remote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants