Update Docker image to Node 22 on Debian Bookworm #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 10 and Debian Buster have been unsupported for a distressingly long
time.
As well as being good practice, this also fixes a failure to start the
service with winston v3.14.1, released yesterday.
/opt/eos-activation-server/node_modules/winston/lib/winston/transports/console.js:24
_consoleLog = console.log.bind(console);
^
SyntaxError: Unexpected token =
bull, i18n-iso-countries, soap and uuid were used by some historical code that was not part of the open-source release. In the archived internal repo, the relevant code was removed in commit 787f18f3b4a096e2bf59d31323fec65f051d2d97 in 2021.
Srdjan originally wrote the bulk of the code, but has not worked on this project for many years.
When this service was open-sourced we applied GPL-2.0-or-later headers to every file in commit d2f41d1, but missed this one.
dbnicholson
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 10 and Debian Buster have been unsupported for a distressingly long
time.
As well as being good practice, this also fixes a failure to start the
service with winston v3.14.1, released yesterday.
I also removed a number of unused dependencies, and fixed package.json a little.
https://phabricator.endlessm.com/T35607