Skip to content

Commit

Permalink
rumtimes/js: better error message when error coercion fails (#1748)
Browse files Browse the repository at this point in the history
Co-authored-by: André Eriksson <[email protected]>
  • Loading branch information
fredr and eandre authored Feb 3, 2025
1 parent 55597f7 commit 806c12f
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions runtimes/js/src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ pub fn coerce_to_api_error(env: Env, val: napi::JsUnknown) -> Result<api::Error,
.get_named_property::<napi::JsUnknown>("details")
.and_then(parse_pvalues)
.map(|val| val.map(Box::new))
.map_err(|_| api::Error {
.map_err(|e| api::Error {
code: api::ErrCode::Internal,
message: api::ErrCode::Internal.default_public_message().into(),
internal_message: Some("an unknown exception was thrown".into()),
internal_message: Some(format!("unable to parse error details: {}", e)),
details: None,
stack: None,
})?;
Expand All @@ -29,10 +29,10 @@ pub fn coerce_to_api_error(env: Env, val: napi::JsUnknown) -> Result<api::Error,
.get_named_property::<JsUnknown>("message")
.and_then(|val| val.coerce_to_string())
.and_then(|val| env.from_js_value(val))
.map_err(|_| api::Error {
.map_err(|e| api::Error {
code: api::ErrCode::Internal,
message: api::ErrCode::Internal.default_public_message().into(),
internal_message: Some("an unknown exception was thrown".into()),
internal_message: Some(format!("unable to parse error message: {}", e)),
details: None,
stack: None,
})?;
Expand Down

0 comments on commit 806c12f

Please sign in to comment.