Skip to content

Make dependencies optional #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make dependencies optional #224

wants to merge 1 commit into from

Conversation

carlwgeorge
Copy link
Contributor

resolves #219

@tomchristie tomchristie mentioned this pull request Oct 16, 2018
Closed
@almarklein
Copy link
Contributor

I think this also closes #135; [all] would simply not work on Windows.

@tomchristie
Copy link
Member

@almarklein Yes. In fact we should close that now, since it's not the approach we want to take.

@carlwgeorge
Copy link
Contributor Author

Does this need any other changes to merge?

@tomchristie
Copy link
Member

I think it's exactly what we want yup, but probably best to wait for a 0.4 release before we pull it in.

@almarklein
Copy link
Contributor

I'd like to get this in. I'd have time to rebase this, if @carlwgeorge is ok with that.

@carlwgeorge
Copy link
Contributor Author

@almarklein Sure, go for it.

@almarklein almarklein mentioned this pull request Feb 10, 2019
Closed
@tomchristie
Copy link
Member

Closing in favor of #298

@carlwgeorge carlwgeorge deleted the options branch February 13, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use optional package installs.
3 participants
@carlwgeorge @almarklein @tomchristie