Get iscoroutinefunction() from inspect rather than asyncio #2855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.14.0a3 issues a
DeprecationWarning
forasyncio.iscoroutinefunction()
, stating that it is deprecated and slated for removal in Python 3.16, and recommendinginspect.iscoroutinefunction()
instead. This change resolves thatDeprecationWarning
.Summary
Running the tests with Python 3.14.0a3 fails with several errors like:
This PR just implements the recommended migration from
asyncio.iscoroutinefunction()
toinspect.iscoroutinefunction()
instarlette/_utils.py
. Note thatstarlete/routing.py
already usesinspect.iscoroutinefunction()
even before this PR:starlette/starlette/routing.py
Line 55 in 4d72fd8
Checklist