Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Drop private imports from test_proxies.py #2850

Merged
merged 1 commit into from
Sep 16, 2023
Merged

test: Drop private imports from test_proxies.py #2850

merged 1 commit into from
Sep 16, 2023

Conversation

YDX-2147483647
Copy link
Contributor

@YDX-2147483647 YDX-2147483647 commented Sep 16, 2023 •
edited
Loading

Summary

Refactor a test case that imports from private namespace, as suggested in #2492.

The original version constructs URLPatterns to compare. This PR destructs them.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change. (This is a test refactor)
  • I've updated the documentation accordingly. (No code changed)

@YDX-2147483647 YDX-2147483647 changed the title Drop private imports from test_proxies.py test: Drop private imports from test_proxies.py Sep 16, 2023
tomchristie
tomchristie approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 😊

@tomchristie tomchristie merged commit e4241c6 into encode:master Sep 16, 2023
4 checks passed
@YDX-2147483647 YDX-2147483647 deleted the refactor/proxies-private-imports branch September 17, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YDX-2147483647 @tomchristie