Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unneccessary private import in tests #2498

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Drop unneccessary private import in tests #2498

merged 2 commits into from
Dec 12, 2022

Conversation

tomchristie
Copy link
Member

Refs #2492

There's no need to import brotli here. We're only using it to create some broken compressed content. (We do a compression, then slice it.)

Instead, just use some nonsense content. That'll raise the same DecodingError.

@tomchristie tomchristie added the refactor Issues and PRs related to code refactoring label Dec 8, 2022
@tomchristie tomchristie merged commit af56476 into master Dec 12, 2022
@tomchristie tomchristie deleted the drop-private-import-from-test-responses branch December 12, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
refactor Issues and PRs related to code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomchristie @zanieb