Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new typing style #963

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Use new typing style #963

merged 2 commits into from
Oct 10, 2024

Conversation

zrquan
Copy link
Contributor

@zrquan zrquan commented Oct 9, 2024 •
edited
Loading

Summary

Switch to new typing style, close #962.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

T-256
T-256 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@T-256 T-256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@tomchristie tomchristie merged commit 127505b into encode:master Oct 10, 2024
5 checks passed
@tomchristie tomchristie mentioned this pull request Oct 10, 2024
Closed
@zrquan zrquan deleted the new-typing branch October 10, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

@T-256 T-256 T-256 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use __future__.annotations
3 participants
@zrquan @tomchristie @T-256