Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix validation for ListSerializer" #9283

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Revert "Fix validation for ListSerializer" #9283

merged 1 commit into from
Mar 13, 2024

Conversation

auvipy
Copy link
Member

@auvipy auvipy commented Mar 13, 2024

Reverts #8979

@auvipy auvipy mentioned this pull request Mar 13, 2024
Merged
browniebroke
browniebroke approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case it helps, checked the diff and it looks good 👍🏻

@sevdog
Copy link
Contributor

sevdog commented Mar 13, 2024

Good for me, I hope we get something to address both #9244 and #8926 following the guidelines stated in the doc in the next release.

@tomchristie
Copy link
Member

Should we also update the CHANGELOG.md here?

@tomchristie tomchristie merged commit a677b09 into master Mar 13, 2024
9 checks passed
@tomchristie tomchristie deleted the revert-8979-fix/list_serializer_validation branch March 13, 2024 15:15
@auvipy
Copy link
Member Author

auvipy commented Mar 14, 2024

Should we also update the CHANGELOG.md here?

yes we should revert the changelog related to this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@browniebroke browniebroke browniebroke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@auvipy @sevdog @tomchristie @browniebroke