[WIP] Integrate coreapi v3. #5855
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this to create a virualenv for testing the integration. * Update requirements-optionals (for tox)
carltongibson
commented
Mar 1, 2018
| schema = coreschema.Object(properties=properties, required=required) | ||
| return mark_safe(coreschema.render_to_form(schema)) | ||
| schema = typesys.Object(properties=properties, required=required) | ||
| return mark_safe(render_to_form(schema)) |
There was a problem hiding this comment.
This is the missing helper. You'll see I've just blocked in an assert False above for the moment.
carltongibson
force-pushed
the
38/coreapi
branch
from
9a31ddb to
210739f
Compare
|
Closing in favour of #6119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the work from core-api/python-client#156 into DRF.
coreschemaforcoreapi.typesys.encoderather thandumpin the renderer.Apart from the missing
render_to_formhelper (c.f. core-api/python-client#160) That's about it, for a first pass.Now, lets see if I got the CI config right for this...