Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data types 'amplitude' and 'phase' #254

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

prisae
Copy link
Member

@prisae prisae commented Sep 5, 2021

  • Add to receivers the method .data_type
    • complex
    • amplitude
    • phase
  • Add to receivers the method .derivative_chain
  • Add a data.complex data set:
    • data.complex contains always the complex data
    • data.synthetic contains data in the form of data_type, which is the same type as data.observed
  • Add to receivers the method .from_complex; this can be used to obtain the data in the form of data_type from complex data: rec.from_complex(data).
  • These changes have to be implemented throughout the Simulation class.
  • Verify implementation and add tests!

@coveralls
Copy link

coveralls commented Sep 5, 2021

Pull Request Test Coverage Report for Build 1654674648

  • 19 of 45 (42.22%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 99.241%

Changes Missing Coverage Covered Lines Changed/Added Lines %
emg3d/electrodes.py 3 12 25.0%
emg3d/simulations.py 10 27 37.04%
Totals Coverage Status
Change from base Build 1654355318: -0.6%
Covered Lines: 4184
Relevant Lines: 4216

💛 - Coveralls

@prisae prisae force-pushed the other-data-types branch 2 times, most recently from d00ddf3 to f5dbb1a Compare October 27, 2021 12:20
@prisae
Copy link
Member Author

prisae commented Mar 2, 2022

I start to thing that the chain rule for different data types should go to the residual/misfit computation, instead of how we have it now...

@prisae prisae marked this pull request as draft August 28, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants