Allowing to use a package url #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trungleduc
reviewed
Sep 27, 2024
include/pyjs/pre_js/load_pkg.js
Outdated
| @@ -108,7 +108,7 @@ Module["bootstrap_from_empack_packed_environment"] = async function | |||
| pkg, | |||
| verbose | |||
| ) { | |||
| let package_url = `${package_tarballs_root_url}/${pkg.filename}` | |||
| let package_url = pkg?.url ? pkg.url :`${package_tarballs_root_url}/${pkg.filename}` | |||
There was a problem hiding this comment.
Suggested change
| let package_url = pkg?.url ? pkg.url :`${package_tarballs_root_url}/${pkg.filename}` | |
| const package_url = pkg?.url ?? `${package_tarballs_root_url}/${pkg.filename}` |
include/pyjs/pre_js/load_pkg.js
Outdated
| @@ -126,7 +126,7 @@ Module["bootstrap_from_empack_packed_environment"] = async function | |||
|
|
|||
| async function bootstrap_python(prefix, package_tarballs_root_url, python_package, verbose) { | |||
| // fetch python package | |||
| let python_package_url = `${package_tarballs_root_url}/${python_package.filename}` | |||
| let python_package_url = python_package?.url ? python_package.url : `${package_tarballs_root_url}/${python_package.filename}` | |||
There was a problem hiding this comment.
Suggested change
| let python_package_url = python_package?.url ? python_package.url : `${package_tarballs_root_url}/${python_package.filename}` | |
| const python_package_url = python_package?.url ?? `${package_tarballs_root_url}/${python_package.filename}` |
trungleduc
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the part of the solution of https://github.com/QuantStack/qs.ai/issues/28
This is updated version of #69 , but packages will be able to use a full url to be downloaded. It will be expected that
empack_env_meta.jsonfile will allow havingurlfor packages and if it is present then this url will be used to download a certain package. If not, the default behavior will be taken.This PR should be used together with jupyterlite/xeus#120