Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of reserved word "package" as variable name #50

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Remove use of reserved word "package" as variable name #50

merged 2 commits into from
Feb 5, 2024

Conversation

trentfridey
Copy link
Contributor

The load_pkg.js function uses the future reserved word package as a variable name. This causes an error for projects using webpack or other tools (#44).

This patch replaces package with pkg in load_pkg.js

@trentfridey trentfridey mentioned this pull request Oct 3, 2023
Closed
@DerThorsten DerThorsten merged commit 164bebb into emscripten-forge:main Feb 5, 2024
1 check passed
@DerThorsten
Copy link
Collaborator

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerThorsten DerThorsten DerThorsten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trentfridey @DerThorsten