-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Allow setting of CLOSURE_ARGS in ports #24192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the only test that fails. It doesn't seem to be related to my changes but please let me know if it is.
|
sbc100
reviewed
Apr 27, 2025
sbc100
approved these changes
Apr 27, 2025
sbc100
approved these changes
Apr 27, 2025
The |
sbc100
approved these changes
Apr 28, 2025
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Apr 28, 2025
Support added in Emscripten in the next release: emscripten-core/emscripten#24192 Tested with Emscripten 4.0.3 and emsdk's `tot` release. No-Try: true Bug: 371024051 Change-Id: I63eb5d6c8cdf43389cf9c09876acddd7b3f0a2a4 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/239474 Auto-Submit: Kai Ninomiya <[email protected]> Commit-Queue: Loko Kung <[email protected]> Reviewed-by: Loko Kung <[email protected]>
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
May 1, 2025
This version supports port files setting --closure-args, so we want it to be able to simplify build steps. emscripten-core/emscripten#24192 Bug: 414330682 Change-Id: I7123613c064bfb763693fcb741c41aee4818506a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/239494 Reviewed-by: Loko Kung <[email protected]> Commit-Queue: Loko Kung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation that was discussed in #24109
I can update the Changelog in a later commit if the tests pass in CI and this PR is approved.
other.test_closure_externs
to make sure that the changes were not affecting existing codeother.test_closure_args_from_port
that piggy back ontest_closure_externs
to pass the same parameter in the port instead and make sure that these changes actually do what they are supposed to do in the first place.Hopefully I didn't forget anything. The changes are pretty straightforward in the grand scheme of things.