Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-char fix!Finally, a little more complicated.
This PR introduces a new test. This test calls
getifaddrs()
, which internally would ultimately callsetmsg()
.The problem was there: calling
getifaddrs()
makesdest
here undefined, butsock.type === {{{ cDefs.SOCK_DGRAM }}}
would betrue
.The current behaviour would skip then the assignement and
dest
would be called just after, but throw asdest
would beundefined
.My solution is to make sure to set
dest
even if thesock.type
matches. Just to be sure, after the condition, I force the sock type. Therefore, I think the intent of #22630 is respected.Fixes #23046.