Remove MAYBE_WASM2JS settings #24176
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll probably wait a couple more release before landing this. |
kripken
approved these changes
Apr 23, 2025
| @@ -59,6 +59,9 @@ See docs/process.md for more on how version tagging works. | |||
| - EXTRA_EXPORTED_RUNTIME_METHODS: Instead use EXPORTED_RUNTIME_METHODS. | |||
| - DEMANGLE_SUPPORT: Instead use the `$demangle` JS libary function. | |||
| (#23975) | |||
| - The `-sMAYBE_WASM2JS` settings was removed. This is oringally added for | |||
There was a problem hiding this comment.
Suggested change
| - The `-sMAYBE_WASM2JS` settings was removed. This is oringally added for | |
| - The `-sMAYBE_WASM2JS` settings was removed. This was originally added for |
| @@ -59,6 +59,9 @@ See docs/process.md for more on how version tagging works. | |||
| - EXTRA_EXPORTED_RUNTIME_METHODS: Instead use EXPORTED_RUNTIME_METHODS. | |||
| - DEMANGLE_SUPPORT: Instead use the `$demangle` JS libary function. | |||
| (#23975) | |||
| - The `-sMAYBE_WASM2JS` settings was removed. This is oringally added for | |||
| debugging purposed, and we now have `-sWASM=2` for folks that want to be able | |||
There was a problem hiding this comment.
Suggested change
| debugging purposed, and we now have `-sWASM=2` for folks that want to be able | |
| debugging purposes, and we now have `-sWASM=2` for folks that want to be able |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #23970 which deprecated the setting.
Fixes: #23969