Improve warning message when ignore fake shared libraries. NFC #23594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Feb 5, 2025
tools/link.py
Outdated
| @@ -2894,7 +2894,7 @@ def filter_out_fake_dynamic_libs(options, inputs): | |||
| def is_fake_dylib(input_file): | |||
| if get_file_suffix(input_file) in DYLIB_EXTENSIONS and os.path.exists(input_file) and not building.is_wasm_dylib(input_file): | |||
| if not options.ignore_dynamic_linking: | |||
| diagnostics.warning('emcc', 'ignoring dynamic library %s because not compiling to JS or HTML, remember to link it when compiling to JS or HTML at the end', os.path.basename(input_file)) | |||
| diagnostics.warning('emcc', 'ignoring dynamic library %s when generating an object file, this will need to be included in the final link', os.path.basename(input_file)) | |||
There was a problem hiding this comment.
Suggested change
| diagnostics.warning('emcc', 'ignoring dynamic library %s when generating an object file, this will need to be included in the final link', os.path.basename(input_file)) | |
| diagnostics.warning('emcc', 'ignoring dynamic library %s when generating an object file, this will need to be manually included in the final link', os.path.basename(input_file)) |
I think "remember to" was saying this must be done explicitly and manually. Seems good to keep that, as otherwise "this will need to be included" might sound like "the linker will do it".
There was a problem hiding this comment.
I went with "included explictily"
Also, add a test for this warning which was previously not tested.
sbc100
force-pushed
the
object_warning
branch
from
0752500 to
27117ab
Compare
kripken
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add a test for this warning which was previously not tested.