[test] Consistent use of cmake_minimum_required in test code. NFC #23538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
cmake_minimum_required
branch
from
0e36ca2 to
9cf87e3
Compare
kripken
reviewed
Jan 30, 2025
test/minimal_webgl/CMakeLists.txt
Outdated
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required(VERSION 2.8) | |||
| cmake_minimum_required(VERSION 3.29) | |||
sbc100
force-pushed
the
cmake_minimum_required
branch
from
9cf87e3 to
1966547
Compare
kripken
approved these changes
Jan 30, 2025
Lower values were causing cmake to print verbose warnings on each test run. I chose 3.16 here since that is the version available in ubuntu/focal which is the oldest version we test against AFAICT.
sbc100
force-pushed
the
cmake_minimum_required
branch
from
1966547 to
f819267
Compare
|
Downgraded to 3.16 since we still test on ubuntu focal. |
kripken
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower values were causing cmake to print verbose warnings on each test run.
I chose 3.16 here since that is the version available in ubuntu/focal which is the oldest version we test against AFAICT.