Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AUDIO_WORKLET] Optimise the copy back from wasm's heap to JS #22753

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[AUDIO_WORKLET] Optimise the copy back from wasm's heap to JS #22753

wants to merge 5 commits into from
+62 −18

Commits on Oct 18, 2024

  1. Logging and notes for me

    @cwoffenden
    cwoffenden committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    45f9cc4 View commit details
    Browse the repository at this point in the history

  2. Better error message (to see why it fails)

    @cwoffenden
    cwoffenden committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    53e20ca View commit details
    Browse the repository at this point in the history

  3. Create one-time fixed views into the heap 

    We can remove the float-by-float JS copy and replace with this simple TypedArray set() calls.
    @cwoffenden
    cwoffenden committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    9b3dbb6 View commit details
    Browse the repository at this point in the history

  4. Allow the number of channels to increase (or the audio chain to change) 

    Typed views are recreated if needed but otherwise are reused.
    @cwoffenden
    cwoffenden committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d4680ca View commit details
    Browse the repository at this point in the history

  5. Work in progress, moved the output buffers first 

    Lots of juggling with the various pointers, and next will be to reduce the code and move all of the output first to stop repeating some of the calculations. Some can also move to the constructor.
    @cwoffenden
    cwoffenden committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    baf7a59 View commit details
    Browse the repository at this point in the history