Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove try/catch from intArrayFromBase64. NFC #20375

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Remove try/catch from intArrayFromBase64. NFC #20375

merged 1 commit into from
Oct 3, 2023

Commits on Oct 3, 2023

  1. Remove try/catch from intArrayFromBase64. NFC 

    It seems like the error is strictly worse than just letting the
exception propagate out.  For example, we have a report of someone
hitting this error but I can't tell what the root cause was:
emscripten-core#20349

This try/catch and this error message was part of the original
function back emscripten-core#5296 but I don't see any reason for them.
    @sbc100
    sbc100 committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    a77941f View commit details
    Browse the repository at this point in the history