add OTP retry minutes

emrecoskun705 · Sep 13, 2023 · 3e6fc14 · 3e6fc14
1 parent c605652
commit 3e6fc14
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/Unitagram.Application/Models/Identity/OTP/EmailOtpSettings.cs b/Unitagram.Application/Models/Identity/OTP/EmailOtpSettings.cs
@@ -4,4 +4,5 @@ public record EmailOtpSettings
 {
     public string Name { get; init; } = string.Empty;
     public int RetryCount { get; init; }
+    public int OtpRetryMinutes { get; init; } 
 }
diff --git a/Unitagram.Identity/Services/EmailVerificationService.cs b/Unitagram.Identity/Services/EmailVerificationService.cs
@@ -116,10 +116,10 @@ public async Task<Result<bool>> ValidateAsync(Guid userId, string token)
     private string GenerateRandom6DigitCode()
     {
         using var rng = RandomNumberGenerator.Create();
-        var bytes = new byte[4]; // Dört bayt uzunluğunda bir dizi oluşturuyoruz.
-        rng.GetBytes(bytes); // Rastgele baytları dolduruyoruz.
-        int code = BitConverter.ToInt32(bytes, 0) % 1000000; // 6 haneli bir sayı üretiyoruz.
-        if (code < 0) code *= -1; // Negatif bir sayıyı pozitife çeviriyoruz.
+        var bytes = new byte[4]; // Create bytes in length 4.
+        rng.GetBytes(bytes); // fill bytes randomly.
+        int code = BitConverter.ToInt32(bytes, 0) % 1000000; // create 6 digit code.
+        if (code < 0) code *= -1; // if it is negative make it positive.
         return code.ToString("D6"); // Format as a 6-digit string
     }
     private bool IsRetryTimeElapsed(OtpConfirmation otpConfirmation)
@@ -137,7 +137,7 @@ private double CalculateMinutesDifference(DateTimeOffset retryDateTime)
 
     private async Task CreateOtpConfirmation(Guid userId, string purpose, string token)
     {
-        var retryDateTime = DateTimeOffset.Now.AddMinutes(15);
+        var retryDateTime = DateTimeOffset.Now.AddMinutes(_emailOtpSettings.OtpRetryMinutes);
         var otpConfirmation = new OtpConfirmation()
         {
             UserId = userId,
@@ -152,7 +152,7 @@ private async Task CreateOtpConfirmation(Guid userId, string purpose, string tok
 
     private async Task UpdateOtpConfirmation(Guid userId, string purpose, string token)
     {
-        var retryDateTime = DateTimeOffset.Now.AddMinutes(15);
+        var retryDateTime = DateTimeOffset.Now.AddMinutes(_emailOtpSettings.OtpRetryMinutes);
         var otpConfirmation = new OtpConfirmation()
         {
             UserId = userId,

diff --git a/Unitagram.WebAPI/appsettings.json b/Unitagram.WebAPI/appsettings.json
@@ -24,7 +24,8 @@
     },
     "EmailOtpSettings": {
         "Name": "emailverification",
-        "RetryCount": 7
+        "RetryCount": 7,
+        "OtpRetryMinutes": 15
     },
     "Serilog": {
         "MinimumLevel": "Error",