Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submodule msquic #299

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Add submodule msquic #299

merged 1 commit into from
Oct 5, 2024

Conversation

elvyso
Copy link
Contributor

@elvyso elvyso commented Sep 27, 2024

relates to #261
Adding submodule/msquic will help us identify and address potential vulnerabilities in the code.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11064795511

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 86.738%

Files with Coverage Reduction New Missed Lines %
c_src/quicer_nif.c 1 84.46%
Totals Coverage Status
Change from base Build 10956999496: 0.09%
Covered Lines: 3898
Relevant Lines: 4494

💛 - Coveralls

@qzhuyan
Copy link
Collaborator

qzhuyan commented Sep 27, 2024

Thanks for the PR.
CI are failing, if I understand correctly, submodules/msquic are not used by default thus try remove "submodules: recursive" in all the files under .github/workflows/

pushd submodules/msquic
git checkout "$VERSION"
popd
rm -f msquic
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rm -f msquic
rm -rf msquic

@qzhuyan qzhuyan changed the base branch from main to next October 5, 2024 09:20
@qzhuyan qzhuyan merged commit bacaac2 into emqx:next Oct 5, 2024
3 of 32 checks passed
@qzhuyan
Copy link
Collaborator

qzhuyan commented Oct 5, 2024

merge branch to next and we will fix there, thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants